Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyphen on privacy-invasive #8427

Closed

Conversation

AdamTranquilla
Copy link

@AdamTranquilla AdamTranquilla commented Apr 3, 2021

Resolves brave/brave-browser#14768

"privacy invasive actions" should be "privacy-invasive actions" in malicious-site warning

This issue was also fixed in several other unspecified locations

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@AdamTranquilla AdamTranquilla changed the title Fix hyphen on privacy-invasive #14768 Fix hyphen on privacy-invasive Apr 3, 2021
@srirambv srirambv requested a review from mkarolin April 23, 2021 12:12
@@ -312,7 +312,7 @@ month ...</translation>
<translation id="5440744330377972191">Websites load faster</translation>
<translation id="3000738865641747653">Loading less data means websites in Brave load faster – up to 8x faster than other browsers.</translation>
<translation id="8903462729414407077">Get weekly updates</translation>
<translation id="8029219208182772618">Be informed about which websites you visit are the most privacy invasive.\n\nOnly you can see these privacy statistics. No personal data or browsing history ever leaves the Brave browser on your device.</translation>
<translation id="8029219208182772618">Be informed about which websites you visit are the most privacy-invasive.\n\nOnly you can see these privacy statistics. No personal data or browsing history ever leaves the Brave browser on your device.</translation>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.xtb files are generated by pulling translations from our localization service. Please, don't edit them.

@@ -754,7 +754,7 @@
<translation id="2468755552460246661">Domain blocked</translation>
<translation id="6631469728138660166">Suspicious site ahead</translation>
<translation id="983774928604730749">Brave has prevented the following site from loading:</translation>
<translation id="8250033559824599347">This site may be fraudulent, bounce you between various sites to set tracking cookies, or perform other privacy invasive actions.</translation>
<translation id="8250033559824599347">This site may be fraudulent, bounce you between various sites to set tracking cookies, or perform other privacy-invasive actions.</translation>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.xtb files shouldn't be edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"privacy invasive actions" should be "privacy-invasive actions" in malicious-site warning
2 participants